Skip to content

Fix test_compression_disabled to expect correct value for scylla #366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 15, 2024
Merged

Fix test_compression_disabled to expect correct value for scylla #366

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions tests/integration/standard/test_metadata.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
greaterthancass21, assert_startswith, greaterthanorequalcass40,
greaterthanorequaldse67, lessthancass40,
TestCluster, DSE_VERSION, requires_java_udf, requires_composite_type,
requires_collection_indexes, xfail_scylla)
requires_collection_indexes, SCYLLA_VERSION)

from tests.util import wait_until

Expand Down Expand Up @@ -531,14 +531,14 @@ def test_collection_indexes(self):
tablemeta = self.get_table_metadata()
self.assertIn('(full(b))', tablemeta.export_as_string())

#TODO: Fix Scylla or test
@xfail_scylla('Scylla prints `compression = {}` instead of `compression = {\'enabled\': \'false\'}`.')
def test_compression_disabled(self):
create_statement = self.make_create_statement(["a"], ["b"], ["c"])
create_statement += " WITH compression = {}"
self.session.execute(create_statement)
tablemeta = self.get_table_metadata()
expected = "compression = {}" if CASSANDRA_VERSION < Version("3.0") else "compression = {'enabled': 'false'}"
expected = "compression = {'enabled': 'false'}"
if SCYLLA_VERSION is not None or CASSANDRA_VERSION < Version("3.0"):
expected = "compression = {}"
self.assertIn(expected, tablemeta.export_as_string())

def test_non_size_tiered_compaction(self):
Expand Down