Make MAPPED_SCYLLA_VERSION a soft requirement #372
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkropachev
force-pushed
the
dk/make-mapped-scylla-version-a-soft-requirement
branch
2 times, most recently
from
c79c41e to
9c90863
Compare
|
Looking at the changes I think you may have slightly wrong idea about what this variable is. |
dkropachev
force-pushed
the
dk/make-mapped-scylla-version-a-soft-requirement
branch
2 times, most recently
from
1178f1d to
822fa7c
Compare
Lorak-mmk
requested changes
Aug 20, 2024
tests/integration/__init__.py
Outdated
Comment on lines
204
to
206
| CASSANDRA_VERSION = Version(mcv_string) if mcv_string else cassandra_version | ||
| CCM_VERSION = mcv_string if mcv_string else cv_string | ||
|
|
There was a problem hiding this comment.
Those seem to be duplicated from the lines above
It is going to ease development and test process. From now on if you want to run it on release you can just run it as such: SCYLLA_VERSION="6.0.2" pytest ....
dkropachev
force-pushed
the
dk/make-mapped-scylla-version-a-soft-requirement
branch
from
822fa7c to
6e2a736
Compare
Lorak-mmk
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is going to ease development and test process.
From now on if you want to run it on release you can just run it as such: