Skip to content

Conversation

dkropachev
Copy link
Collaborator

It is marked to be depricated, we need to stop using it.
It also spams following warnings in tests:

DeprecationWarning: ResultSet indexing support will be removed in 4.0. Consider using ResultSet.one() to get a single row.

Pre-review checklist

  • I have split my patch into logically separate commits.
  • All commit messages clearly explain what they change and why.
  • I added relevant tests for new features and bug fixes.
  • All commits compile, pass static checks and pass test.
  • PR description sums up the changes and reasons why they should be introduced.
  • I have provided docstrings for the public items that I want to introduce.
  • I have adjusted the documentation in ./docs/source/.
  • I added appropriate Fixes: annotations to PR description.

@dkropachev dkropachev force-pushed the dk/stop-result-indexing-in-tests branch from 9ae1357 to bd0a29a Compare December 20, 2024 00:16
@dkropachev dkropachev force-pushed the dk/stop-result-indexing-in-tests branch 4 times, most recently from 80acf44 to 78dc3a2 Compare December 20, 2024 17:13
It is marked to be depricated, we need to stop using it.
It also spams following warnings in tests:
DeprecationWarning: ResultSet indexing support will be removed in 4.0. Consider using ResultSet.one() to get a single row.
@dkropachev dkropachev force-pushed the dk/stop-result-indexing-in-tests branch from 78dc3a2 to e24acab Compare December 20, 2024 17:54
@dkropachev dkropachev merged commit 347f332 into master Dec 20, 2024
27 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants