Skip to content

Conversation

Lorak-mmk
Copy link

@Lorak-mmk Lorak-mmk commented Jul 11, 2025

We don't use them, and never will. The only thing they do is making init.py of integration tests more bloated, and any refactors to tests code more dofficult.
Most unit tests are not removed (for now) because they don't require stuff from __init__.py, or working DB, so they are mostly harmless (and I'm pretty sure we actually run them).

Progress towards: #207

Pre-review checklist

  • I have split my patch into logically separate commits.
  • All commit messages clearly explain what they change and why.
  • I added relevant tests for new features and bug fixes.
  • All commits compile, pass static checks and pass test.
  • PR description sums up the changes and reasons why they should be introduced.
  • I have provided docstrings for the public items that I want to introduce.
  • I have adjusted the documentation in ./docs/source/.
  • I added appropriate Fixes: annotations to PR description.

@Lorak-mmk Lorak-mmk requested a review from dkropachev July 11, 2025 17:29
@Lorak-mmk Lorak-mmk self-assigned this Jul 11, 2025
@Lorak-mmk Lorak-mmk changed the title Remove DSE tests Remove DSE integration tests Jul 14, 2025
We don't use them. The only thing they do is making __init__.py of
integration tests more bloated.
@Lorak-mmk
Copy link
Author

Rebased on master

@Lorak-mmk Lorak-mmk requested a review from dkropachev July 16, 2025 11:36
@dkropachev dkropachev merged commit e022378 into scylladb:master Jul 16, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants