Skip to content

Conversation

mykaul
Copy link

@mykaul mykaul commented Aug 10, 2025

We don't support it anymore, it's therefore a query we can remove altogether.

Pre-review checklist

  • I have split my patch into logically separate commits.
  • All commit messages clearly explain what they change and why.
  • I added relevant tests for new features and bug fixes.
  • All commits compile, pass static checks and pass test.
  • PR description sums up the changes and reasons why they should be introduced.
  • I have provided docstrings for the public items that I want to introduce.
  • I have adjusted the documentation in ./docs/source/.
  • I added appropriate Fixes: annotations to PR description.

@mykaul
Copy link
Author

mykaul commented Aug 10, 2025

Ref. scylladb/scylladb@88ae067 to where it was removed.

We don't support it anymore, it's therefore a query we can remove altogether.

Signed-off-by: Yaniv Kaul <[email protected]>
@mykaul mykaul requested a review from Copilot August 10, 2025 18:22
Copilot

This comment was marked as outdated.

@mykaul mykaul requested a review from Copilot August 10, 2025 20:57
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes support for in-memory Scylla tables by eliminating queries to the system_schema.scylla_tables table and related processing logic. The change simplifies the metadata querying code since in-memory tables are no longer supported.

  • Removes queries to system_schema.scylla_tables
  • Eliminates logic for processing and aggregating Scylla-specific table metadata
  • Removes handling of the in_memory table property

@roydahan roydahan requested a review from dkropachev August 11, 2025 10:39
@dkropachev dkropachev merged commit c8d35ca into scylladb:master Aug 11, 2025
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants