Skip to content

Conversation

tmandke
Copy link

@tmandke tmandke commented Mar 16, 2021

No description provided.

@sds
Copy link
Owner

sds commented May 1, 2021

Appreciate the pull request, @tmandke.

An inheritance feature would be useful, but a straight up Hash#merge call is perhaps too simple. We would likely want to implement some form of deep merge, or at least consider what other tools in the space do (e.g. RuboCop).

Furthermore, some tests that assert the desired merge behavior should be included if we'd like to see this merged. Thank you!

@sds sds closed this May 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants