Skip to content

Conversation

@khalkie
Copy link
Contributor

@khalkie khalkie commented Feb 8, 2023

…ssing in the case of remote calls to sign/verify an envelope (i.e. a KMS call)

@coveralls
Copy link

coveralls commented Feb 9, 2023

Pull Request Test Coverage Report for Build 4145744285

  • 6 of 6 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 91.632%

Totals Coverage Status
Change from base Build 3856310937: 0.0%
Covered Lines: 219
Relevant Lines: 239

💛 - Coveralls

@adityasaky adityasaky requested a review from shibumi February 9, 2023 15:12
@adityasaky
Copy link
Member

@khalkie could you squash your commits? They all have the same message. Thanks!

@adityasaky
Copy link
Member

Also, we should quickly check who we'd break with this change.

…ssing in the case of remote calls to sign/verify an envelope (i.e. a KMS call)
@khalkie
Copy link
Contributor Author

khalkie commented Feb 10, 2023

Also, we should quickly check who we'd break with this change.

Thanks! I've squashed the commits but I'm unsure how to check what it has broken. Do you do that, or can you show me how to do it?

@khalkie
Copy link
Contributor Author

khalkie commented Feb 14, 2023

Please advise next steps

@adityasaky
Copy link
Member

Thanks for the patch, @khalkie! We've cut a release of go-sslib with this included (s/o @shibumi) and working on updating in-toto-golang to support it as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants