Only use sha 512 #71
Merged
Only use sha 512 #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Joshua Lock <[email protected]>
lukpueh
requested changes
Nov 21, 2019
Member
lukpueh
left a comment
lukpueh
left a comment
There was a problem hiding this comment.
I cross-checked the numbers with the updated spreadsheet, and they add up. There's a typo in one formula (see inline suggestions). Other than that LGTM! :)
Co-Authored-By: lukpueh <[email protected]>
lukpueh
approved these changes
Nov 21, 2019
lukpueh
pushed a commit
to lukpueh/peps
that referenced
this pull request
Nov 22, 2019
secure-systems-lab#71 removed sha256 hashes from targets metadata and correctly updated the metadata calculation in the tables, but not in the text. This commit updates the relevant numbers in the text. It further fixes an unrelated wording mistake in the metadata calc section.
This was referenced Nov 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I removed mentions of sha256 per #67 and redid the metadata overhead calculations.
Please double check my math on the metadata calculations.