-
Notifications
You must be signed in to change notification settings - Fork 2
Fix broken links #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix broken links #26
Conversation
@PhilReedData I replace the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @kdp-cloud, I've added some suggestions where (a) I had not yet removed the .html bit from some links, and (b) some of the links had not yet been made to work with relative_url.
Still to do:
- Add to the contribution guide a note about how to do links with relative_url and why.
- Merge / sync latest changes from main.
Do you know how to do number 2? I can look at writing something for 1 but I don't know if I have permission to make changes directly to this branch.
0118e20
to
b7cfe09
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tested locally, images still work on all pages for me. I've written updates to the contribution guidance page to match these changes, but I don't have permission to push them. I'll apply them right after merging this PR.
When using a
baseurl
in _config.yml, links to an absolute path (mostly images) do not resolve.This will fix deployments of the documentation under a sub-URI or GitHub pages.