Skip to content

Conversation

kdp-cloud
Copy link
Contributor

@kdp-cloud kdp-cloud commented Mar 24, 2025

When using a baseurl in _config.yml, links to an absolute path (mostly images) do not resolve.

This will fix deployments of the documentation under a sub-URI or GitHub pages.

Copilot

This comment was marked as outdated.

@kdp-cloud kdp-cloud requested a review from Copilot April 3, 2025 12:47
Copilot

This comment was marked as outdated.

@kdp-cloud kdp-cloud requested a review from PhilReedData April 3, 2025 12:49
@kdp-cloud
Copy link
Contributor Author

@PhilReedData I replace the site.baseurl with relative_url.

Copy link
Collaborator

@PhilReedData PhilReedData left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @kdp-cloud, I've added some suggestions where (a) I had not yet removed the .html bit from some links, and (b) some of the links had not yet been made to work with relative_url.

Still to do:

  1. Add to the contribution guide a note about how to do links with relative_url and why.
  2. Merge / sync latest changes from main.

Do you know how to do number 2? I can look at writing something for 1 but I don't know if I have permission to make changes directly to this branch.

@kdp-cloud kdp-cloud requested a review from Copilot April 7, 2025 12:37
Copilot

This comment was marked as resolved.

@kdp-cloud kdp-cloud requested a review from PhilReedData April 7, 2025 12:40
Copy link
Collaborator

@PhilReedData PhilReedData left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested locally, images still work on all pages for me. I've written updates to the contribution guidance page to match these changes, but I don't have permission to push them. I'll apply them right after merging this PR.

@PhilReedData PhilReedData merged commit 723fb15 into seek4science:main Apr 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants