This repository was archived by the owner on Aug 27, 2021. It is now read-only.
Don't shadow library name in variable name #897
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was unclear before which of the `sendgrid` were references to the package and which were references to the variable name. Hopefully this changes makes that more clear.
|
Thanks so much! |
|
Thanks for contributing to SendGrid Open Source! We think it's awesome when community members contribute to our projects and want to celebrate that. The following link will ask you to authenticate with Github (so we can verify your identity), it will then ask for a little bit more information and we'll then send you a thanks for contributing. Once again, thank you! |
mbernier
pushed a commit
that referenced
this pull request
Jan 21, 2015
Don't shadow library name in variable name
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was unclear before which of the
sendgridwere references to the package and which were references to the variable name. Hopefully this changes makes that more clear.