Add serde support behind a feature flag #51
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reduces serialport's compile time slightly, and removes memoffset as an indirect dependency.
Default port timeout of zero may cause the hardware_check example to fail when reading data with the '--loopback' flag. Added 250ms timeout delay to allow the test to pass when data is not immediately available. Signed-off-by: mlsvrts <[email protected]>
Contributor
Author
|
I think I've somehow messed up the git history a bit in my attempt to squash my commits and put them at the "end" of current HEAD. Apologies |
jessebraham
approved these changes
May 9, 2022
Member
jessebraham
left a comment
jessebraham
left a comment
There was a problem hiding this comment.
Thanks for this! I think the version of the serde dependency is probably fine as it is, this is how I normally have seen it in my experience.
No worries regarding the git stuff, it happens. Should be able to rebase just fine (I hope 😁).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pretty much does what it says on the tin :).
The dep I've written is
serde = { version = "1.0", features = ["derive"], optional = true }which I think is fine, but perhaps more versions of serde should be supported?