Accessors such as a.B should be case-sensitive
#100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@nblumhardt LGTM if we are releasing in a breaking change version, is there anything we should include in the new major? |
Member
Author
|
👍 #97 is also binary-breaking, though we could get around that with some overloads if we think it'll be an issue in real-world deployment (I'm guessing currently that it won't be). |
Member
Author
|
Also updating the Serilog dependency to 3.x |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bugfix, but needs to be in a new major because it's also a breaking change.
ElementAt(a, b) ciplays the role of a case-insensitive accessor.