Skip to content

added .NET Standard 2.0 compatibility #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 3, 2021
Merged

added .NET Standard 2.0 compatibility #25

merged 2 commits into from
Mar 3, 2021

Conversation

@f2calv
Copy link
Contributor

@f2calv f2calv commented Mar 3, 2021

fixes #24

nblumhardt
nblumhardt requested changes Mar 3, 2021
View reviewed changes
Copy link
Member

@nblumhardt nblumhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Had a few comments but otherwise can't see anything preventing this from moving forward.

@f2calv
Copy link
Contributor Author

f2calv commented Mar 3, 2021

ok, all valid points & done.

@nblumhardt nblumhardt merged commit e10eae6 into serilog:dev Mar 3, 2021
@nblumhardt
Copy link
Member

nblumhardt commented Mar 3, 2021

Great, thanks! 👍

@nblumhardt nblumhardt mentioned this pull request Mar 7, 2021
Merged
@dependabot dependabot bot mentioned this pull request Mar 13, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nblumhardt nblumhardt nblumhardt requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add a .NET Standard 2.0 target

2 participants

@f2calv @nblumhardt