UseSerilog() goodness #101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nblumhardt
commented
Aug 24, 2017
| { | ||
| var configuration = new ConfigurationBuilder() | ||
| .SetBasePath(Directory.GetCurrentDirectory()) | ||
| .AddJsonFile("appsettings.json", optional: false, reloadOnChange: true) |
There was a problem hiding this comment.
One slight annoyance here - any idea how to get the information about the hosting environment - Development, Production etc. - without resolving IHostingEnvironment from DI?
nblumhardt
commented
Aug 24, 2017
| </ItemGroup> | ||
|
|
||
| <ItemGroup Condition=" '$(TargetFramework)' == 'net461' or '$(TargetFramework)' == 'netstandard2.0' "> | ||
| <PackageReference Include="Microsoft.AspNetCore.Hosting.Abstractions" Version="2.0.0" /> |
There was a problem hiding this comment.
This one's a bit unfortunate, as David points out. Still may not be much of a problem in practice. Could split UseSerilog() out to a separate package, if we want to...?
This was referenced Aug 25, 2017
|
As per recent discussions lets get this in. We can always iterate before this ships. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #98
See the included sample Program.cs files for usage.