Skip to content

Conversation

nblumhardt
Copy link
Member

@gkinsman
Copy link

Looks good! I think it makes sense to fail silently into SelfLog and not attempt to write the log message with parameter holes. Would asserting on SelfLog having no output be a useful test for library authors to catch these bad events?

@nblumhardt
Copy link
Member Author

Thanks for taking a look. Asserting on the absence of SelfLog output, or on the presence of the expected events, would do the job; I'm not sure if Microsoft.Extensions.Logging provides it, but at least for Serilog, the SerilogAnalyzer VS plug-in catches these issues, too.

@nblumhardt nblumhardt merged commit c695457 into serilog:dev Mar 2, 2020
@nblumhardt
Copy link
Member Author

Thanks, George! Would be great to hear how the -dev package goes, should be on its way through CI -> NuGet now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants