Do not swallow exception from Audit #218
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimonCropp
reviewed
Mar 11, 2023
src/Serilog.Extensions.Logging/Extensions/Logging/SerilogLogger.cs
Outdated
Show resolved
Hide resolved
nblumhardt
reviewed
Mar 11, 2023
| Write(level, eventId, state, exception, formatter, out parsed); | ||
| } | ||
| catch (Exception ex) | ||
| catch (Exception ex) when (!parsed) |
There was a problem hiding this comment.
To make the code clearer, could Write become PrepareWrite, with out ILogger logger, out LogEvent evt?
PrepareWrite() would then be called in the try/catch block, and logger.Write(evt) outside it, yielding the same behavior but avoiding the need for the parsed Boolean (which is a bit tricky to follow).
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #209
I spent a few hours today to figure out why my sink from audit config not throwing an exception. Without this fix audit sink as a feature is useless when working through MEL.