Skip to content

Provide dispose flag to opt-in to provider disposing logger #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 14, 2016
Merged

Provide dispose flag to opt-in to provider disposing logger #42

merged 2 commits into from
Jul 14, 2016

Conversation

@nblumhardt
Copy link
Member

@nblumhardt nblumhardt commented Jul 13, 2016

#41

@nblumhardt nblumhardt merged commit f9941c1 into serilog:dev Jul 14, 2016
@colin-young
Copy link

colin-young commented Jul 15, 2016

After thinking about defaulting to dispose: true if passing in a logger a bit more, I agree that it would introduce more unexpected side-effects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nblumhardt @colin-young