add TString deallocation step #128
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I compare TString usage in cppflow and tensorflow's unittest, it seems that deallocation step may be required. But I did not check actual implementation of TString, so if I am wrong, please let it go.
https://github.com/tensorflow/tensorflow/blob/2305f9d0a58921987788fbd1d8fa43eda888233f/tensorflow/core/platform/ctstring_test.cc#L34-L68