Feature/support_exact_version #247
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@theburningmonk |
|
@horike37 yup, will do |
|
@horike37 done |
horike37
approved these changes
Aug 19, 2019
|
🎉 This PR is included in version 2.5.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
ss-betseqnzr
pushed a commit
to BetSEQNZR/serverless-step-functions
that referenced
this pull request
Sep 8, 2023
…act_version Feature/support_exact_version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #240
To enable this feature, I had to make two changes:
to add
lambda:InvokeFunctionpermissions to<function arn>:*always, since state machines share the same IAM role (unfortunately). This is to cater for the fact that if you deploy withuseExactVersion: falsethen deploy again withuseExactVersion: truethen the shared IAM role would need to execute against botharn:aws:...:function-nameas well asarn:aws:...:function-name:version.add a configuration for
useExactVersionand when it's enabled, iterate through the captured function ARNs and swap them out for the corresponding Lambda version.Besides these, I added a schema definition for the state machine object itself so it's defined in one place and we can remove quite a few if conditions from
compileStateMachine.js.