Use libc definitions wherever they are provided #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since gaol was first written, most system definitions have made their way into the libc crate (with good test coverage against various libc implementations). Make an attempt to use those definitions wherever reasonable.
|
@bors-servo retry |
|
@posborne: 🔑 Insufficient privileges: not in try users |
|
@bors-servo r+ |
|
📌 Commit df8ce8c has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Nov 17, 2018
Use libc definitions wherever they are provided Since gaol was first written, most system definitions have made their way into the libc crate (with good test coverage against various libc implementations and platforms). This conversion was fairly mechanical. There's a mix of pulling libc definitions into the namespace and using the `libc::`. If there is a preference one way or the other I can certainly amend the commit with the preferred style. This codebase could probably use a good `rustfmt` too but for this change I avoided that (except for on platform/unix/process.rs which had been thoroughly touched already). r? @pcwalton
|
☀️ Test successful - status-travis |
This was referenced Nov 17, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since gaol was first written, most system definitions have made their way into the libc crate (with good test coverage against various libc implementations and platforms).
This conversion was fairly mechanical. There's a mix of pulling libc definitions into the namespace and using the
libc::. If there is a preference one way or the other I can certainly amend the commit with the preferred style. This codebase could probably use a goodrustfmttoo but for this change I avoided that (except for on platform/unix/process.rs which had been thoroughly touched already).r? @pcwalton