Skip to content

fix: limit joined_at to timestamp in seconds or throw #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 16, 2024
Merged

fix: limit joined_at to timestamp in seconds or throw #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2229986
fix: limit joined_at to seconds up to 01/01/2100
Bilb Dec 9, 2024
6784541
chore: no need for explicit node-gyp install anymore
Bilb Dec 16, 2024
328f774
fix: use the same values as libsession-util
Bilb Dec 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,12 +44,6 @@ jobs:
uses: microsoft/[email protected]
if: runner.os == 'Windows'

- name: Setup node for windows
if: runner.os == 'Windows'
shell: bash
run: |
yarn global add node-gyp@latest

# - name: sed it
# if: runner.os == 'Windows'
# shell: bash
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"main": "index.js",
"name": "libsession_util_nodejs",
"description": "Wrappers for the Session Util Library",
"version": "0.4.7",
"version": "0.4.8",
"license": "GPL-3.0",
"author": {
"name": "Oxen Project",
Expand Down
4 changes: 4 additions & 0 deletions src/user_groups_config.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,6 +314,10 @@ Napi::Value UserGroupsWrapper::setGroup(const Napi::CallbackInfo& info) {
obj.Get("joinedAtSeconds"), "UserGroupsWrapper::setGroup joinedAtSeconds")) {
group_info.joined_at = *joinedAtSeconds;
}
// Probably an invalid timestamp.
if (group_info.joined_at > 9000000000) {
throw std::invalid_argument{"group.joined_at is too far in the future"};
}

if (auto invited = maybeNonemptyBoolean(
obj.Get("invitePending"), "UserGroupsWrapper::setGroup invitePending")) {
Expand Down
Loading