feat: localize core pages #17

Aerilym · 2025-07-24T01:43:12Z

No description provided.

Copilot

Pull Request Overview

This PR implements internationalization (i18n) support for the core pages of the Session website using next-intl, enabling multi-language support across the site. The change introduces a comprehensive localization system with support for 16 languages including English, German, French, Spanish, and more.

Adds next-intl integration with locale-specific routing and content
Replaces hardcoded strings with translation keys across components and pages
Implements language selection dialog with proper ARIA accessibility

Reviewed Changes

Copilot reviewed 54 out of 58 changed files in this pull request and generated 8 comments.

Show a summary per file

File	Description
pages/*.tsx	Updates all core pages to support localization with getStaticProps and locale keys
pages/api/sitemap.ts	Enhanced sitemap generation with multilingual URL structure and hreflang support
pages/_app.tsx	Integrates NextIntlClientProvider for i18n context
pages/_document.tsx	Adds RTL language direction detection
locales/*.json	Translation files for 16 supported languages
components/ui/Layout.tsx	Updates Layout component to accept localeKey prop
components/sections/*.tsx	Replaces hardcoded text with translation hooks
components/navigation/*.tsx	Implements localized navigation with language picker
constants/*	Updates navigation and metadata constants for i18n compatibility
package.json	Adds next-intl and related dependencies

Files not reviewed (1)

pnpm-lock.yaml: Language not supported

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-08-21T05:46:05Z

pages/download.tsx

              <div className={classNames(noteContainerClasses, 'pb-12', 'lg:pb-0')}>
                <p className={classNames(notesClasses)}>
-                  Verify Signatures:
+                  {t('verifySignatures', { platforms: '' })}


The platforms parameter is passed as an empty string but the translation keys suggest this should contain platform-specific information. This will result in incomplete text like 'Verify Signatures: ' instead of 'Verify Signatures: Android, iOS'.

Suggested change

{t('verifySignatures', { platforms: '' })}

{t('verifySignatures', { platforms: 'Android, iOS' })}

Copilot · 2025-08-21T05:46:06Z

pages/download.tsx

                </p>
                <p className={classNames(notesClasses)}>
-                  Release Notes:
+                  {t('releaseNotes', { platforms: '' })}


The platforms parameter is passed as an empty string but the translation keys suggest this should contain platform-specific information. This will result in incomplete text like 'Verify Signatures: ' instead of 'Verify Signatures: Android, iOS'.

Suggested change

{t('releaseNotes', { platforms: '' })}

{t('releaseNotes', { platforms: 'Android, iOS' })}

Copilot · 2025-08-21T05:46:06Z

pages/download.tsx

              <div className={classNames(noteContainerClasses, 'md:pb-16', 'lg:pb-0')}>
                <p className={classNames(notesClasses)}>
-                  Verify Signatures:
+                  {t('verifySignatures', { platforms: '' })}


The platforms parameter is passed as an empty string but the translation keys suggest this should contain platform-specific information. This will result in incomplete text like 'Verify Signatures: ' instead of 'Verify Signatures: Android, iOS'.

Suggested change

{t('verifySignatures', { platforms: '' })}

{t('verifySignatures', { platforms: 'Desktop' })}

Copilot · 2025-08-21T05:46:06Z

pages/download.tsx

                </p>
                <p className={classNames(notesClasses)}>
-                  Release Notes:
+                  {t('releaseNotes', { platforms: '' })}


The platforms parameter is passed as an empty string but the translation keys suggest this should contain platform-specific information. This will result in incomplete text like 'Verify Signatures: ' instead of 'Verify Signatures: Android, iOS'.

Suggested change

{t('releaseNotes', { platforms: '' })}

{t('releaseNotes', { platforms: _tGeneral('desktop') })}

Copilot · 2025-08-21T05:46:07Z

locales/en.json

+    "hero": {
+      "heading": "Send <glitch>Messages,</glitch> Not Metadata.",
+      "tag": "Find your freedom with {appName}",
+      "glitchTextGlitch": "Encrypted"


The English locale file contains HTML-like tags () but other locale files use a different format with 'format' and separate 'glitchTextPrimary'/'glitchTextGlitch' keys. This inconsistency could cause rendering issues in the English version.

Suggested change

"glitchTextGlitch": "Encrypted"

"format": "Send {glitchTextPrimary} {glitchTextGlitch} Not Metadata.",

"glitchTextPrimary": "Messages,",

"glitchTextGlitch": "Encrypted",

"tag": "Find your freedom with {appName}"

Copilot · 2025-08-21T05:46:07Z

locales/ach.json

+    "appSupport": "crwdns38066:0{appName}crwdne38066:0",
+    "socials": "crwdns38068:0crwdne38068:0",
+    "aria": {
+      "socialLink": "crwdns38070:0{appName}crwdnd38070:0{platform}crwdne38070:0",


The Crowdin placeholder format uses 'crwdnd' as a delimiter between parameters, but this appears to be a typo - it should likely be 'crwdne' to match the pattern used elsewhere in the file.

Suggested change

"socialLink": "crwdns38070:0{appName}crwdnd38070:0{platform}crwdne38070:0",

"socialLink": "crwdns38070:0{appName}crwdne38070:0{platform}crwdne38070:0",

Copilot · 2025-08-21T05:46:07Z

pages/api/sitemap.ts

+
+const redirects: IRedirection[] = await config.redirects();
+const locales: Array<string> = config.i18n.locales;
+const defaultLocale: string = config.i18n.defaultLocale;


Top-level await is used outside of an async function context. This will cause a syntax error. These declarations should be moved inside the async handler function.

Suggested change

const defaultLocale: string = config.i18n.defaultLocale;

Copilot · 2025-08-21T05:46:07Z

components/navigation/Locale.tsx

+  } catch {
+    return locale.toUpperCase();
+  }
+}


The of() method can return undefined for invalid locale codes, but the function signature doesn't account for this. The return should be explicitly typed to handle the undefined case or provide a fallback.

Suggested change

}

function getLanguageDisplayName(locale: string): string {

try {

const displayName = new Intl.DisplayNames([locale], { type: 'language' }).of(locale);

return displayName ?? locale.toUpperCase();

} catch {

return locale.toUpperCase();

}

Aerilym added 6 commits July 24, 2025 11:42

feat: add next-intl and localization support for core pages

4e22e79

feat: add locale switching and in-context translation support

6d23468

fix: add translation mode

365b52d

feat: force crowdin locale for in-context translate mode

1a6458a

fix: hero text

32fa973

chore: update in-context translations

e8020fc

Copilot AI review requested due to automatic review settings August 21, 2025 05:44

Copilot AI reviewed Aug 21, 2025

View reviewed changes

Aerilym added 6 commits September 4, 2025 16:08

feat: add titles to images and optimise crawler headers

3a88ccb

chore: update locale files

ec5a387

fix: hero wrapping on long text locales

bd7e792

feat: add sitemap priority and frequency

fd4dab9

chore: toggle enabled locales

8300f6e

fix: remove json trailing comma causing search console issues

3ca71bf

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: localize core pages #17

feat: localize core pages #17

Uh oh!

Aerilym commented Jul 24, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Aug 21, 2025

Uh oh!

Copilot AI Aug 21, 2025

Uh oh!

Copilot AI Aug 21, 2025

Uh oh!

Copilot AI Aug 21, 2025

Uh oh!

Copilot AI Aug 21, 2025

Uh oh!

Copilot AI Aug 21, 2025

Uh oh!

Copilot AI Aug 21, 2025

Uh oh!

Copilot AI Aug 21, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

	{t('verifySignatures', { platforms: '' })}
	{t('verifySignatures', { platforms: 'Android, iOS' })}

	{t('releaseNotes', { platforms: '' })}
	{t('releaseNotes', { platforms: 'Android, iOS' })}

	{t('verifySignatures', { platforms: '' })}
	{t('verifySignatures', { platforms: 'Desktop' })}

	{t('releaseNotes', { platforms: '' })}
	{t('releaseNotes', { platforms: _tGeneral('desktop') })}

-      "glitchTextGlitch": "Encrypted"
+      "format": "Send {glitchTextPrimary} {glitchTextGlitch} Not Metadata.",
+      "glitchTextPrimary": "Messages,",
+      "glitchTextGlitch": "Encrypted",
+      "tag": "Find your freedom with {appName}"

	"socialLink": "crwdns38070:0{appName}crwdnd38070:0{platform}crwdne38070:0",
	"socialLink": "crwdns38070:0{appName}crwdne38070:0{platform}crwdne38070:0",

-}
+function getLanguageDisplayName(locale: string): string {
+  try {
+    const displayName = new Intl.DisplayNames([locale], { type: 'language' }).of(locale);
+    return displayName ?? locale.toUpperCase();
+  } catch {
+    return locale.toUpperCase();
+  }

feat: localize core pages #17

Are you sure you want to change the base?

feat: localize core pages #17

Uh oh!

Conversation

Aerilym commented Jul 24, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Aug 21, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 21, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 21, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 21, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 21, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 21, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 21, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 21, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant