Add option or remove log props for errors with server rendering

[justin808]

Since props can be huge, we don't want to log the props when server rendering.

Either:

1. Never log props with server rendering errors
2. Make it another option, possibly piggy-backing on some other option.

CC: @robwise

[robwise]

If we make it another option, I don't think we should piggy-back it, but make it something really specific and obvious like: log_props_with_server_rendering_errors

[benigeri]

We have a a ton of data sent via props during server side rendering. Having them logged as part of the error message quickly becomes noisy and not useful.

I do believe it can be beneficial as people are starting up, especially when they have fairly small props.

log_props_with_server_rendering_errors sounds ideal.

[justin808]

@benigeri

We currently have:

# Default is true. Logs server rendering messages to Rails.logger.info
 config.logging_on_server = true

I think we could:

Change the default of true to not log props

Alternately, somebody, if somebody wanted it, we could add something like "verbose" instead of true.

Are the props ever interesting on the server?

[LyzioOh]

Hey Justin, what about this issue ?
Should we replace
config.logging_on_server = true
by
config.logging_on_server = false
?

[justin808]

@EEtancelin I recommend keeping this as true. If you do change to false, you'll only get logs from React on Rails in the browser.

[jonathanphilippou]

I'll take a look at this

[jonathanphilippou]

If we make it another option, I don't think we should piggy-back it, but make it something really specific and obvious like: log_props_with_server_rendering_errors

i'll try to implement this

[justin808]

Done in #1059.