-
-
Notifications
You must be signed in to change notification settings - Fork 638
Address security alert for gem uglifier #25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update gem uglifier to >= 2.7.2 to address security alert for affected versions prior to 2.7.2 Sources: lautis/uglifier#86 https://zyan.scripts.mit.edu/blog/backdooring-js/ https://nodesecurity.io/advisories/uglifyjs_incorrectly_handles_non-boolean_comparisons mishoo/UglifyJS#751
Member
|
LGTM -- that old one was in there from the generator, I believe. |
dylangrafmyre
added a commit
that referenced
this pull request
Sep 15, 2015
Address security alert for gem uglifier
justin808
added a commit
that referenced
this pull request
Nov 2, 2025
This comment explains React on Rails' use case for exact version support and provides context for why we had to implement a workaround. To be posted at: shakacode/package_json#25 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
justin808
added a commit
that referenced
this pull request
Nov 3, 2025
This comment explains React on Rails' use case for exact version support and provides context for why we had to implement a workaround. To be posted at: shakacode/package_json#25 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
justin808
added a commit
that referenced
this pull request
Nov 5, 2025
This comment explains React on Rails' use case for exact version support and provides context for why we had to implement a workaround. To be posted at: shakacode/package_json#25 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
justin808
added a commit
that referenced
this pull request
Nov 5, 2025
This comment explains React on Rails' use case for exact version support and provides context for why we had to implement a workaround. To be posted at: shakacode/package_json#25 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
justin808
added a commit
that referenced
this pull request
Nov 5, 2025
This comment explains React on Rails' use case for exact version support and provides context for why we had to implement a workaround. To be posted at: shakacode/package_json#25 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
justin808
added a commit
that referenced
this pull request
Nov 5, 2025
This comment explains React on Rails' use case for exact version support and provides context for why we had to implement a workaround. To be posted at: shakacode/package_json#25 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
justin808
added a commit
that referenced
this pull request
Nov 6, 2025
This comment explains React on Rails' use case for exact version support and provides context for why we had to implement a workaround. To be posted at: shakacode/package_json#25 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
justin808
added a commit
that referenced
this pull request
Nov 7, 2025
This comment explains React on Rails' use case for exact version support and provides context for why we had to implement a workaround. To be posted at: shakacode/package_json#25 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update gem uglifier to >= 2.7.2 to address security alert for affected
versions prior to 2.7.2
Sources: lautis/uglifier#86
https://zyan.scripts.mit.edu/blog/backdooring-js/
https://nodesecurity.io/advisories/uglifyjs_incorrectly_handles_non-boolean_comparisons
mishoo/UglifyJS#751