[WIP] Additional VM config (for review) #17

dhlaluku · 2018-07-11T12:16:14Z

Description

Currently, CloudStack does not allow additional configuration metadata to guest VMs during deployment. This feature aims to provide operators the functionality to pass arbitrary additional configuration metadata that will be included everytime the guest VM is started.

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)

GitHub Issue/PRs

Screenshots (if appropriate):

How Has This Been Tested?

Checklist:

I have read the CONTRIBUTING document.
My code follows the code style of this project.
My change requires a change to the documentation.
I have updated the documentation accordingly.
Testing
I have added tests to cover my changes.
All relevant new and existing integration tests have passed.
A full integration testsuite with all test that can run on my environment has passed.

* Update Apache DBCP version * Fix DB connection * Prevent hang on the db creation

from "cleanued up" to "cleaned up"

…#2649) This is to fix the regression added in apache#2433. In this fix we're going to fail the build early if --use-timestamp is provided and working directory is *not* clean. And also fail the build if something in the script has returned non-zero value.

…e#2640) Two stages are defined in travis job: test and package, where test runs before package. On package stage we're going to do the packaging of final artifacts based on centos7, centos63, ubuntu1804, ubuntu1604 and ubuntu1404. This is to validate that no PR will break packaging artifacts.

This is a new feature for CS that allows Admin users improved troubleshooting of network issues in CloudStack hosted networks. Description: For troubleshooting purposes, CloudStack administrators may wish to execute network utility commands remotely on system VMs, or request system VMs to ping/traceroute/arping to specific addresses over specific interfaces. An API command to provide such functionalities is being developed without altering any existing APIs. The targeted system VMs for this feature are the Virtual Router (VR), Secondary Storage VM (SSVM) and the Console Proxy VM (CPVM). FS: https://cwiki.apache.org/confluence/display/CLOUDSTACK/CloudStack+Remote+Diagnostics+API ML discussion: https://markmail.org/message/xt7owmb2c6iw7tva

… XSS) (apache#2524) * [CLOUDSTACK-9261] Upgrate jQuery-UI to 1.11 (JQuery UI 1.8.4 prone to XSS) * fix problems in the UI for lbCertificatePolicy and StaticNAT * force jenkins build * Fix about dialog * Fix position of network service offering

Support multiple volume access groups per compute cluster

…apache#2709) * only ask for the root volume, removing extensive query * better name

* Refactor userVmDetailsDao field and remove unusued fields * Setting injected attributes to private instead of protected and amending unit test

…2703) There was a concurrency problem with the “moveNetworkAclItem” API method. If two users were changing the ACL rules order at the same time, this could lead to inconsistent actions. To solve the problem we added a “consistency check ” parameter, which is used to hold the consistency hash. This hash is created using an MD5 hash function on a String that is created with all ACL rules UUIDs concatenated in their order, which is defined via the ‘number’ field. We also lock the editing of the ACL while executing the upgrade. This allows us to handle race conditions nicely, and present a good feedback for the user.

…s true (apache#2756) This PR fixes NPE with the provisionCertificateCmd when reconnect is set to True. Also fixes the following Marvin test failures: - test_certauthority_root.py

…apache#2732) In 6233a77 as a part of PR apache#2432 the bash() function was replaced by the execute() function. Somehow this last calling of the bash() function was not caught by testing and is still in there. This causes Exceptions to be thrown by the Security Group script. Signed-off-by: Wido den Hollander <[email protected]>

On the 'Register Template From URL' screen, when a user selects the KVM option from the Hypervisor dropdown: 1) It incorrectly displays the 'Original XS Version is 6.1' checkbox. This checkbox should be hidden in the KVM context. 2) The 'Root Disk Controller' dropdown should display the default option of 'osdefault' instead of a blank default option.

* 4.11: register template kvm context ui fix (apache#2757) check volumes for state when retrieving pool for configDrive creation (apache#2709)

…replacement (apache#2636) * Fix limitation on tag matching in 'migrateVolume' with disk offering replacement When the feature to enable disk offering replacement during volume migration was created, we were forcing the tags of the new disk offering to exact the same as the tags of the target storage poll. However, that is not how ACS manages volumes allocation. This change modifies this validation to make it consistent with volume allocation. * Address Nitin's suggestions * Apply Daan's suggestion regarding "doesTargetStorageSupportDiskOffering" method * fix problem

DaanHoogland

I don't see the use for the boolean. The presence of the string is indication enough additional metadata is used. please explain?

DaanHoogland · 2018-07-24T14:12:49Z

api/src/main/java/com/cloud/agent/api/to/VirtualMachineTO.java


    Double cpuQuotaPercentage = null;

+    boolean enableExtraConfig = false;


do we need this boolean if there is a string (that could be null)?

Thanks for spotting that, it seems redundant since I do not use it anywhere just yet and maybe should be removed during code refactoring. This is basically an initial implementation to test the MVP.

…oyment

Fixes: #17 Fixes: #18 These dependencies are necessary or eslint will fail with the standard vue.js rule set. The PR also includes fixes for all lint errors. Signed-off-by: Rohit Yadav <[email protected]>

* Explicitly controlling VMware VM hardware version * Add unit tests and add defensive checks

db: Update Apache DBCP version (apache#2718)

9fb36e7

* Update Apache DBCP version * Fix DB connection * Prevent hang on the db creation

dhlaluku force-pushed the addconfig-to-vm branch 2 times, most recently from b77de0f to 187b794 Compare July 11, 2018 12:54

dhlaluku changed the title ~~Add extra configuration to VM during deployment~~ [WIP] Additional VM config (for review) Jul 11, 2018

GabrielBrascher and others added 16 commits July 11, 2018 18:12

Fix typo in VirtualMachineManagerImpl.java (apache#2738)

2936cb3

from "cleanued up" to "cleaned up"

Support multiple volume access groups per compute cluster

73608de

Merge pull request apache#2503 from mike-tutkowski/multi-sf-vags

99bc0e6

Support multiple volume access groups per compute cluster

check volumes for state when retrieving pool for configDrive creation (…

38d0274

…apache#2709) * only ask for the root volume, removing extensive query * better name

Refactor userVmDetailsDao field and remove unusued fields (apache#2750)

94dedd6

* Refactor userVmDetailsDao field and remove unusued fields * Setting injected attributes to private instead of protected and amending unit test

fix provisionCertificate api returns NPE when 'reconnect' parameter i…

a6e0204

…s true (apache#2756) This PR fixes NPE with the provisionCertificateCmd when reconnect is set to True. Also fixes the following Marvin test failures: - test_certauthority_root.py

Merge release branch 4.11 to master

c3ff356

* 4.11: register template kvm context ui fix (apache#2757) check volumes for state when retrieving pool for configDrive creation (apache#2709)

api: remove empty response parameters (apache#2751)

a21ebb1

DaanHoogland reviewed Jul 24, 2018

View reviewed changes

dhlaluku force-pushed the addconfig-to-vm branch 2 times, most recently from bea5c05 to 6f0e787 Compare July 24, 2018 15:15

Add extra parameter to accept additional configuration during VM depl…

d044870

…oyment

dhlaluku force-pushed the addconfig-to-vm branch from 6f0e787 to d044870 Compare July 24, 2018 15:19

dhlaluku closed this Jul 25, 2018

dhlaluku deleted the addconfig-to-vm branch July 25, 2018 08:48

shwstppr pushed a commit that referenced this pull request Jul 27, 2021

[4.11.3] Explicitly controlling VMware VM hardware version (#17)

db5aa33

* Explicitly controlling VMware VM hardware version * Add unit tests and add defensive checks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[WIP] Additional VM config (for review) #17

[WIP] Additional VM config (for review) #17

Uh oh!

dhlaluku commented Jul 11, 2018

Uh oh!

DaanHoogland left a comment

Uh oh!

DaanHoogland Jul 24, 2018

Uh oh!

dhlaluku Jul 24, 2018 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants


		Double cpuQuotaPercentage = null;

		boolean enableExtraConfig = false;

[WIP] Additional VM config (for review) #17

[WIP] Additional VM config (for review) #17

Uh oh!

Conversation

dhlaluku commented Jul 11, 2018

Description

Types of changes

GitHub Issue/PRs

Screenshots (if appropriate):

How Has This Been Tested?

Checklist:

Uh oh!

DaanHoogland left a comment

Choose a reason for hiding this comment

Uh oh!

DaanHoogland Jul 24, 2018

Choose a reason for hiding this comment

Uh oh!

dhlaluku Jul 24, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

dhlaluku Jul 24, 2018 •

edited

Loading