ui: add memory used column in instance metrics view #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds memory used column in the instance metrics view. Also fixes a bug for VMware, due to which incorrect memory usage was returned. Signed-off-by: Rohit Yadav <[email protected]>
DaanHoogland
approved these changes
Mar 13, 2019
Member
Author
|
Moved apache#3243 |
rohityadavcloud
pushed a commit
that referenced
this pull request
Jan 20, 2021
Make the api url for development configurable via env file Signed-off-by: Rohit Yadav <[email protected]>
rohityadavcloud
pushed a commit
that referenced
this pull request
Jan 20, 2021
This fixes #33 Signed-off-by: Rohit Yadav <[email protected]>
shwstppr
pushed a commit
that referenced
this pull request
Jul 27, 2021
Upload ISO from local backport from 4.13
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: The metrics view for instances does not show used memory.
Root Cause: Used memory was not added as a column in the metrics view for instances.
Solution: Metrics view for instances makes ‘listVirtualMachineMetrics’ API call to gather metrics. The response of this API call contains total and free memory with the instance. These have been used to compute used memory as a percentage of total memory and displayed as a new column in UI. Also fixes
a bug for VMware, due to which incorrect memory usage was returned.
Types of changes