ui: instance settings visibility #38
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change allows instance Settings tab to be visible but inaccessible when instance is running. A warning is shown when user tries to access Settings for a running instance and tab content is greyed out. It also allows some admin defined instance settings/details to be made static for user. User will be able to see them in instance settings tab but cannot change their values as action buttons are disabled and greyed out. This can be achieved by providing a comma-separated list details for global settings key 'user.vm.readonly.ui.details'. A new value 'readonlyuidetails' has been added in UserVMResponse for UI manipulate editing functionality of settings/details. Signed-off-by: Abhishek Kumar <[email protected]>
Member
Author
|
Moved apache#3244 |
rohityadavcloud
added a commit
that referenced
this pull request
Jan 20, 2021
This uses project displaytext instead of name when available. Fixes #38 Signed-off-by: Rohit Yadav <[email protected]>
rohityadavcloud
added a commit
that referenced
this pull request
Jan 20, 2021
- Reusable details settings component for VM and templates, with autocompletion of options - Instancegroup feature - split monitor into individual event and alert tabs, move alerts to infra - reimplement logo - project selection refactorings - use password input for relevant fields Signed-off-by: Rohit Yadav <[email protected]>
shwstppr
added a commit
that referenced
this pull request
Aug 16, 2021
Signed-off-by: Abhishek Kumar <[email protected]> ui: fix UI label bug #28 (#34) Signed-off-by: Abhishek Kumar <[email protected]> fix system vm migration with zone wide storage (#35) * fix system vm migration with zone wide storage Signed-off-by: Abhishek Kumar <[email protected]> * fix Signed-off-by: Abhishek Kumar <[email protected]> * fix spacing Signed-off-by: Abhishek Kumar <[email protected]> * add empty volumes check Signed-off-by: Abhishek Kumar <[email protected]> fix fr568 issue #28 (#36) Fixes systemvm migration with zone-wide storage Check only for usable volumes Signed-off-by: Abhishek Kumar <[email protected]> vmware: fix error msg for vmotion without shared storage (#37) Fixes error message which wrongly mentions worker VM Signed-off-by: Abhishek Kumar <[email protected]> refactor error message for interpod systemvm migration (#38) Fixes error message introduced in #28 Signed-off-by: Abhishek Kumar <[email protected]>
shwstppr
added a commit
that referenced
this pull request
Nov 23, 2021
Signed-off-by: Abhishek Kumar <[email protected]> ui: fix UI label bug #28 (#34) Signed-off-by: Abhishek Kumar <[email protected]> fix system vm migration with zone wide storage (#35) * fix system vm migration with zone wide storage Signed-off-by: Abhishek Kumar <[email protected]> * fix Signed-off-by: Abhishek Kumar <[email protected]> * fix spacing Signed-off-by: Abhishek Kumar <[email protected]> * add empty volumes check Signed-off-by: Abhishek Kumar <[email protected]> fix fr568 issue #28 (#36) Fixes systemvm migration with zone-wide storage Check only for usable volumes Signed-off-by: Abhishek Kumar <[email protected]> vmware: fix error msg for vmotion without shared storage (#37) Fixes error message which wrongly mentions worker VM Signed-off-by: Abhishek Kumar <[email protected]> refactor error message for interpod systemvm migration (#38) Fixes error message introduced in #28 Signed-off-by: Abhishek Kumar <[email protected]>
vishesh92
pushed a commit
that referenced
this pull request
Sep 9, 2024
* Prevent addition of duplicate PF rules on scale up and no rules left behind on scale down (#32) * fix missing dependency injection * NSX: Fix concurrency issues on port forwarding rules deletion (#37) * Fix concurrency issues on port forwarding rules deletion * Refactor objectExists * Fix unit test * Fix test * Small fixes * CKS: Externalize control and worker node setup wait time and installation attempts (#38) * NSX: Add shared network support (#41) * NSX: Fix number of physical networks for Guest traffic checks and leftover rules on CKS cluster deletion (#45) * Fix pf rules removal on CKS cluster deletion * Fix check for number of physical networks for guest traffic * Fix unit test * fix logger * NSX: Handle CheckHealthCommand to avoid host disconnection and errors on APIs * NSX: Handle CheckHealthCommand to avoid host disconnection and errors on APIs * Remove unused string * fix logger * Update UDP active monitor to ICMP * Fix NPE on restarting VPC with additional public IPs * NSX / VPC: Reuse Source NAT IP from systemVM range on restarts * CKS: Public IP not found for VPC networks * Externalize retries and inverval for NSX segment deletion (#67) * remove unused import * remove duplicate imports * remove unused import * revert externalizing cks settings * fix test * Refactor log messages * Address comments * Fix issue caused due to forward merge: 90fe1d --------- Co-authored-by: Nicolas Vazquez <[email protected]> Co-authored-by: Rohit Yadav <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem: Instance settings tab is visible only for stopped VMs but hidden otherwise. This creates confusion as users may not know that VMs need to be stopped to access settings page. Some VM details need to be read-only for the user.
Root Cause: The UI Code hides the settings tab for VMs that are not in stopped state. Instance setting tab should always be visible, but only changeable when VM is stopped. Required instance details are not read-only for the user.
Solution: The settings tab is now always visible for VMs. If VM is not in the stopped state, no interactions are allowed in the settings tab view by greying out its content and a popup is shown to advise users for stopping the VM. VM details can be made read-only in UI for the user using “user.vm.readonly.ui.details” which accepts a comma-separated list of details. Read-only details will be shown in the settings tab in UI but the action button for them will be disabled and greyed out.
Types of changes
Screenshots (if appropriate):
Snapshot when VM is stopped.
Snapshot when VM is not stopped but Settings tab is clicked and Popup appears
When popup is dismissed
VM setting/detail made read-only
How Has This Been Tested?