-
Notifications
You must be signed in to change notification settings - Fork 126
Refactor TaskRuns out of BuildRun Controller #1924
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor TaskRuns out of BuildRun Controller #1924
Conversation
|
This is a "take two" of my attempt to refactor TaskRuns out of the BuildRun contrller (see #1866). This time I am narrowing the scope a bit and using AI assistance. |
Initial effort to abstract concrete usage of Tekton TaskRuns out of the BuildRun controller. This includes the creation of new a new interface (ImageBuildRunner), factories for converting TaskRuns to ImageBuildRunners, and updates to controller code. Existing "patch" logic for TaskRuns was encapsulated in a formal cancellation method. Assisted-by: Cursor Signed-off-by: Adam Kaplan <[email protected]>
8bf0434 to
66af0cd
Compare
|
Taking WIP off this PR (hopefully the full suite passes 🤞 ) |
|
@adambkaplan Is the eventual aim to have TaskRuns be a completely "optional" or modular component to Shipwright, such that if another imagebuildrunner (in this framework) were to come along that can implement the interfaces in this PR, it would use that instead? |
More the "modular" idea. For multi-arch image builds, orchestrating with a |
dorzel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like a good first step to me given what the intended scope currently is. ImageBuildRunner seems like a reasonable interface and I would expect it would get more generic over time as additional implementations come in.
SaschaSchwarze0
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: SaschaSchwarze0 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Changes
Initial effort to abstract concrete usage of Tekton TaskRuns out of the BuildRun controller. This includes the creation of new a new interface (ImageBuildRunner), factories for converting TaskRuns to ImageBuildRunners, and updates to controller code.
/kind cleanup
Submitter Checklist
See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.
Release Notes