Skip to content
This repository was archived by the owner on Sep 22, 2024. It is now read-only.

Conversation

@telkins
Copy link
Contributor

@telkins telkins commented Oct 5, 2020

Two changes in this PR (sorry):

  • Allow Respondable::respond() to take/pass a resource class
  • Resolve model class only if needed for collection and length aware paginator

The second change (resolving model class) was made for two reasons:

  • it isn't necessary if a resource class is provided
  • some resources aren't model-based, in which case the model resolution throws

@telkins telkins changed the title Allow Respondable::respond() to take/pass a resource class Two unrelated fixes... Oct 5, 2020
@pactode pactode merged commit af6ffbb into signifly:master Oct 6, 2020
@pactode
Copy link
Contributor

pactode commented Oct 6, 2020

Thanks Travis!

@telkins
Copy link
Contributor Author

telkins commented Oct 6, 2020

Thanks Travis!

NP....I might come back and add some tests. My own version of this does a lot of the same stuff with the responder resolving and such. There are some differences, mainly having to do with another "layer" of functionality, but I believe I have some tests that can be easily ported....just need time/energy.

Anyway, I got to looking at my code and this package and realized I can just drop a big chunk of my own stuff and use this, which I started doing last week or so. As I've been using it more, I've run into a couple problems...which this PR solves, of course. 🤓

So....now I'm left have to decide what to do with the remaining functionality...and I'm starting to wonder if it's worthwhile in its own package....or a little too tightly coupled (design-wise) to my own little project. 🤔

Alright....ttyl...

@telkins
Copy link
Contributor Author

telkins commented Oct 6, 2020

@pactode Also...
image
image
😞

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants