-
Notifications
You must be signed in to change notification settings - Fork 932
[Merged by Bors] - Bump libp2p to address inconsistency in mesh peer tracking #2493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulhauner
added a commit
that referenced
this pull request
Aug 4, 2021
commit c103089 Author: Paul Hauner <[email protected]> Date: Wed Aug 4 12:02:33 2021 +1000 Use sigp/rust-libp2p gossipsub-consistency-paul commit a978c7c Author: Paul Hauner <[email protected]> Date: Wed Aug 4 11:27:53 2021 +1000 Bump libp2p
Closed
paulhauner
added a commit
that referenced
this pull request
Aug 4, 2021
commit c103089 Author: Paul Hauner <[email protected]> Date: Wed Aug 4 12:02:33 2021 +1000 Use sigp/rust-libp2p gossipsub-consistency-paul commit a978c7c Author: Paul Hauner <[email protected]> Date: Wed Aug 4 11:27:53 2021 +1000 Bump libp2p
paulhauner
added a commit
that referenced
this pull request
Aug 6, 2021
commit c103089 Author: Paul Hauner <[email protected]> Date: Wed Aug 4 12:02:33 2021 +1000 Use sigp/rust-libp2p gossipsub-consistency-paul commit a978c7c Author: Paul Hauner <[email protected]> Date: Wed Aug 4 11:27:53 2021 +1000 Bump libp2p
3 tasks
paulhauner
added a commit
that referenced
this pull request
Aug 9, 2021
commit c103089 Author: Paul Hauner <[email protected]> Date: Wed Aug 4 12:02:33 2021 +1000 Use sigp/rust-libp2p gossipsub-consistency-paul commit a978c7c Author: Paul Hauner <[email protected]> Date: Wed Aug 4 11:27:53 2021 +1000 Bump libp2p
938cffb to
92995df
Compare
paulhauner
added a commit
that referenced
this pull request
Aug 9, 2021
commit 92995df Author: Paul Hauner <[email protected]> Date: Mon Aug 9 17:08:50 2021 +1000 Freshen Cargo.lock commit 8f9fbcd Author: Paul Hauner <[email protected]> Date: Mon Aug 9 17:04:00 2021 +1000 Update to latest version of libp2p PR commit c36b246 Author: Paul Hauner <[email protected]> Date: Wed Aug 4 12:02:33 2021 +1000 Use sigp/rust-libp2p gossipsub-consistency-paul commit ebb7c2c Author: Paul Hauner <[email protected]> Date: Wed Aug 4 11:27:53 2021 +1000 Bump libp2p
Member
|
This looks fine to me, although I think we should target the master commit once the libp2p PR gets merged |
Member
Author
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Aug 12, 2021
## Issue Addressed - Resolves #2457 - Resolves #2443 ## Proposed Changes Target the (presently unreleased) head of `libp2p/rust-libp2p:master` in order to obtain the fix from libp2p/rust-libp2p#2175. Additionally: - `libsecp256k1` needed to be upgraded to satisfy the new version of `libp2p`. - There were also a handful of minor changes to `eth2_libp2p` to suit some interface changes. - Two `cargo audit --ignore` flags were remove due to libp2p upgrades. ## Additional Info NA
AgeManning
approved these changes
Aug 12, 2021
Member
AgeManning
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Pull request successfully merged into unstable. Build succeeded: |
pawanjay176
pushed a commit
to pawanjay176/lighthouse
that referenced
this pull request
Aug 27, 2021
## Issue Addressed - Resolves sigp#2457 - Resolves sigp#2443 ## Proposed Changes Target the (presently unreleased) head of `libp2p/rust-libp2p:master` in order to obtain the fix from libp2p/rust-libp2p#2175. Additionally: - `libsecp256k1` needed to be upgraded to satisfy the new version of `libp2p`. - There were also a handful of minor changes to `eth2_libp2p` to suit some interface changes. - Two `cargo audit --ignore` flags were remove due to libp2p upgrades. ## Additional Info NA
pawanjay176
pushed a commit
to pawanjay176/lighthouse
that referenced
this pull request
Aug 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
prost(a libp2p dependency) #2443Proposed Changes
Target the (presently unreleased) head of
libp2p/rust-libp2p:masterin order to obtain the fix from libp2p/rust-libp2p#2175.Additionally:
libsecp256k1needed to be upgraded to satisfy the new version oflibp2p.eth2_libp2pto suit some interface changes.cargo audit --ignoreflags were remove due to libp2p upgrades.Additional Info
NA