Skip to content

Conversation

@paulhauner
Copy link
Member

@paulhauner paulhauner commented Aug 4, 2021

Issue Addressed

Proposed Changes

Target the (presently unreleased) head of libp2p/rust-libp2p:master in order to obtain the fix from libp2p/rust-libp2p#2175.

Additionally:

  • libsecp256k1 needed to be upgraded to satisfy the new version of libp2p.
  • There were also a handful of minor changes to eth2_libp2p to suit some interface changes.
  • Two cargo audit --ignore flags were remove due to libp2p upgrades.

Additional Info

NA

@paulhauner paulhauner added the work-in-progress PR is a work-in-progress label Aug 4, 2021
paulhauner added a commit that referenced this pull request Aug 4, 2021
commit c103089
Author: Paul Hauner <[email protected]>
Date:   Wed Aug 4 12:02:33 2021 +1000

    Use sigp/rust-libp2p gossipsub-consistency-paul

commit a978c7c
Author: Paul Hauner <[email protected]>
Date:   Wed Aug 4 11:27:53 2021 +1000

    Bump libp2p
@paulhauner paulhauner mentioned this pull request Aug 4, 2021
paulhauner added a commit that referenced this pull request Aug 4, 2021
commit c103089
Author: Paul Hauner <[email protected]>
Date:   Wed Aug 4 12:02:33 2021 +1000

    Use sigp/rust-libp2p gossipsub-consistency-paul

commit a978c7c
Author: Paul Hauner <[email protected]>
Date:   Wed Aug 4 11:27:53 2021 +1000

    Bump libp2p
paulhauner added a commit that referenced this pull request Aug 6, 2021
commit c103089
Author: Paul Hauner <[email protected]>
Date:   Wed Aug 4 12:02:33 2021 +1000

    Use sigp/rust-libp2p gossipsub-consistency-paul

commit a978c7c
Author: Paul Hauner <[email protected]>
Date:   Wed Aug 4 11:27:53 2021 +1000

    Bump libp2p
@paulhauner paulhauner added the v1.5.0 For inclusion in v1.5.0 release label Aug 9, 2021
@paulhauner paulhauner mentioned this pull request Aug 9, 2021
3 tasks
paulhauner added a commit that referenced this pull request Aug 9, 2021
commit c103089
Author: Paul Hauner <[email protected]>
Date:   Wed Aug 4 12:02:33 2021 +1000

    Use sigp/rust-libp2p gossipsub-consistency-paul

commit a978c7c
Author: Paul Hauner <[email protected]>
Date:   Wed Aug 4 11:27:53 2021 +1000

    Bump libp2p
@paulhauner paulhauner force-pushed the to-be-connected-fix branch from 938cffb to 92995df Compare August 9, 2021 07:09
paulhauner added a commit that referenced this pull request Aug 9, 2021
commit 92995df
Author: Paul Hauner <[email protected]>
Date:   Mon Aug 9 17:08:50 2021 +1000

    Freshen Cargo.lock

commit 8f9fbcd
Author: Paul Hauner <[email protected]>
Date:   Mon Aug 9 17:04:00 2021 +1000

    Update to latest version of libp2p PR

commit c36b246
Author: Paul Hauner <[email protected]>
Date:   Wed Aug 4 12:02:33 2021 +1000

    Use sigp/rust-libp2p gossipsub-consistency-paul

commit ebb7c2c
Author: Paul Hauner <[email protected]>
Date:   Wed Aug 4 11:27:53 2021 +1000

    Bump libp2p
@AgeManning
Copy link
Member

This looks fine to me, although I think we should target the master commit once the libp2p PR gets merged

@paulhauner paulhauner added ready-for-review The code is ready for review and removed work-in-progress PR is a work-in-progress labels Aug 12, 2021
@paulhauner paulhauner marked this pull request as ready for review August 12, 2021 00:13
@paulhauner
Copy link
Member Author

bors r+

@paulhauner paulhauner added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Aug 12, 2021
bors bot pushed a commit that referenced this pull request Aug 12, 2021
## Issue Addressed

- Resolves #2457
- Resolves #2443

## Proposed Changes

Target the (presently unreleased) head of `libp2p/rust-libp2p:master` in order to obtain the fix from libp2p/rust-libp2p#2175.

Additionally:

- `libsecp256k1` needed to be upgraded to satisfy the new version of `libp2p`.
- There were also a handful of minor changes to `eth2_libp2p` to suit some interface changes.
- Two `cargo audit --ignore` flags were remove due to libp2p upgrades.

## Additional Info
 
 NA
Copy link
Member

@AgeManning AgeManning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bors
Copy link

bors bot commented Aug 12, 2021

@bors bors bot changed the title Bump libp2p to address inconsistency in mesh peer tracking [Merged by Bors] - Bump libp2p to address inconsistency in mesh peer tracking Aug 12, 2021
@bors bors bot closed this Aug 12, 2021
bors bot pushed a commit that referenced this pull request Aug 12, 2021
## Issue Addressed

NA

## Proposed Changes

Bump to `v1.5.0-rc.0`.

## TODO

- [x] Manual testing
- [x] Resolve #2493
- [x] Include #2501
bors bot pushed a commit that referenced this pull request Aug 12, 2021
## Issue Addressed

NA

## Proposed Changes

- Bump to `v1.5.0-rc.0`.
- Increase attestation reprocessing queue size (I saw this filling up on Prater).
- Reduce error log for full attn reprocessing queue to warn.

## TODO

- [x] Manual testing
- [x] Resolve #2493
- [x] Include #2501
pawanjay176 pushed a commit to pawanjay176/lighthouse that referenced this pull request Aug 27, 2021
## Issue Addressed

- Resolves sigp#2457
- Resolves sigp#2443

## Proposed Changes

Target the (presently unreleased) head of `libp2p/rust-libp2p:master` in order to obtain the fix from libp2p/rust-libp2p#2175.

Additionally:

- `libsecp256k1` needed to be upgraded to satisfy the new version of `libp2p`.
- There were also a handful of minor changes to `eth2_libp2p` to suit some interface changes.
- Two `cargo audit --ignore` flags were remove due to libp2p upgrades.

## Additional Info
 
 NA
pawanjay176 pushed a commit to pawanjay176/lighthouse that referenced this pull request Aug 27, 2021
## Issue Addressed

NA

## Proposed Changes

- Bump to `v1.5.0-rc.0`.
- Increase attestation reprocessing queue size (I saw this filling up on Prater).
- Reduce error log for full attn reprocessing queue to warn.

## TODO

- [x] Manual testing
- [x] Resolve sigp#2493
- [x] Include sigp#2501
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-merge This PR is ready to merge. v1.5.0 For inclusion in v1.5.0 release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants