Skip to content

Fix consensus, SSZ, tree hash & run merge EF tests #2622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 24, 2021
Merged

Fix consensus, SSZ, tree hash & run merge EF tests #2622

merged 2 commits into from
Sep 24, 2021

Conversation

@michaelsproul
Copy link
Member

@michaelsproul michaelsproul commented Sep 24, 2021

Proposed Changes

  • Update test runners for EF merge tests. All passing!
  • Fix some minor consensus, SSZ and tree hashing issues along the way

Additional Info

@michaelsproul michaelsproul added the ready-for-review The code is ready for review label Sep 24, 2021
paulhauner
paulhauner approved these changes Sep 24, 2021
View reviewed changes
Copy link
Member

@paulhauner paulhauner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@michaelsproul michaelsproul merged commit 5a35ac0 into sigp:merge-f2f Sep 24, 2021
@michaelsproul michaelsproul deleted the merge-spec-tests branch September 24, 2021 04:55
paulhauner pushed a commit to paulhauner/lighthouse that referenced this pull request Sep 27, 2021
@michaelsproul @paulhauner
Fix consensus, SSZ, tree hash & run merge EF tests (sigp#2622)
4759695 
* Update to v1.1.0-beta.4 (squash of sigp#2548)

* SSZ, cached tree hash, EF tests
@paulhauner paulhauner mentioned this pull request Sep 27, 2021
Closed
7 tasks
realbigsean pushed a commit to realbigsean/lighthouse that referenced this pull request Sep 27, 2021
@michaelsproul @realbigsean
Fix consensus, SSZ, tree hash & run merge EF tests (sigp#2622)
08407b1 
* Update to v1.1.0-beta.4 (squash of sigp#2548)

* SSZ, cached tree hash, EF tests
realbigsean added a commit to realbigsean/lighthouse that referenced this pull request Sep 27, 2021
@realbigsean
Revert "Fix consensus, SSZ, tree hash & run merge EF tests (sigp#2622)"
7ac5190 
This reverts commit 08407b1.
paulhauner pushed a commit that referenced this pull request Sep 28, 2021
@michaelsproul @paulhauner
Fix consensus, SSZ, tree hash & run merge EF tests (#2622)
ef6158f 
* Update to v1.1.0-beta.4 (squash of #2548)

* SSZ, cached tree hash, EF tests
paulhauner pushed a commit that referenced this pull request Oct 1, 2021
@michaelsproul @paulhauner
Fix consensus, SSZ, tree hash & run merge EF tests (#2622)
6da6453 
* Update to v1.1.0-beta.4 (squash of #2548)

* SSZ, cached tree hash, EF tests
paulhauner pushed a commit that referenced this pull request Oct 12, 2021
@michaelsproul @paulhauner
Fix consensus, SSZ, tree hash & run merge EF tests (#2622)
1794886 
* Update to v1.1.0-beta.4 (squash of #2548)

* SSZ, cached tree hash, EF tests
paulhauner pushed a commit that referenced this pull request Oct 27, 2021
@michaelsproul @paulhauner
Fix consensus, SSZ, tree hash & run merge EF tests (#2622)
82a1df5 
* Update to v1.1.0-beta.4 (squash of #2548)

* SSZ, cached tree hash, EF tests
paulhauner pushed a commit to paulhauner/lighthouse that referenced this pull request Nov 3, 2021
@michaelsproul @paulhauner
Fix consensus, SSZ, tree hash & run merge EF tests (sigp#2622)
b38203c 
* Update to v1.1.0-beta.4 (squash of sigp#2548)

* SSZ, cached tree hash, EF tests
paulhauner pushed a commit that referenced this pull request Nov 11, 2021
@michaelsproul @paulhauner
Fix consensus, SSZ, tree hash & run merge EF tests (#2622)
de84cdd 
* Update to v1.1.0-beta.4 (squash of #2548)

* SSZ, cached tree hash, EF tests
paulhauner pushed a commit that referenced this pull request Nov 28, 2021
@michaelsproul @paulhauner
Fix consensus, SSZ, tree hash & run merge EF tests (#2622)
0c0fdbf 
* Update to v1.1.0-beta.4 (squash of #2548)

* SSZ, cached tree hash, EF tests
paulhauner pushed a commit that referenced this pull request Nov 28, 2021
@michaelsproul @paulhauner
Fix consensus, SSZ, tree hash & run merge EF tests (#2622)
3b1a269 
* Update to v1.1.0-beta.4 (squash of #2548)

* SSZ, cached tree hash, EF tests
paulhauner pushed a commit that referenced this pull request Dec 2, 2021
@michaelsproul @paulhauner
Fix consensus, SSZ, tree hash & run merge EF tests (#2622)
cce855f 
* Update to v1.1.0-beta.4 (squash of #2548)

* SSZ, cached tree hash, EF tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@paulhauner paulhauner paulhauner approved these changes

Assignees

No one assigned

Labels

ready-for-review The code is ready for review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@michaelsproul @paulhauner