Fix clippy lints on merge-f2f #2626
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulhauner
added
ready-for-review
michaelsproul
approved these changes
Sep 25, 2021
Member
michaelsproul
left a comment
michaelsproul
left a comment
There was a problem hiding this comment.
LGTM, happy to merge once Clippy passes on this branch
Member
Author
|
Clippy passed 🎉 |
paulhauner
added a commit
to paulhauner/lighthouse
that referenced
this pull request
Sep 27, 2021
* Remove unchecked arith from ssz_derive * Address clippy lints in block_verfication * Use safe math for is_valid_gas_limit
realbigsean
pushed a commit
to realbigsean/lighthouse
that referenced
this pull request
Sep 27, 2021
* Remove unchecked arith from ssz_derive * Address clippy lints in block_verfication * Use safe math for is_valid_gas_limit
realbigsean
added a commit
to realbigsean/lighthouse
that referenced
this pull request
Sep 27, 2021
This reverts commit 076e624.
paulhauner
added a commit
that referenced
this pull request
Sep 28, 2021
* Remove unchecked arith from ssz_derive * Address clippy lints in block_verfication * Use safe math for is_valid_gas_limit
paulhauner
added a commit
that referenced
this pull request
Oct 1, 2021
* Remove unchecked arith from ssz_derive * Address clippy lints in block_verfication * Use safe math for is_valid_gas_limit
paulhauner
added a commit
that referenced
this pull request
Oct 12, 2021
* Remove unchecked arith from ssz_derive * Address clippy lints in block_verfication * Use safe math for is_valid_gas_limit
paulhauner
added a commit
that referenced
this pull request
Oct 27, 2021
* Remove unchecked arith from ssz_derive * Address clippy lints in block_verfication * Use safe math for is_valid_gas_limit
paulhauner
added a commit
to paulhauner/lighthouse
that referenced
this pull request
Nov 3, 2021
* Remove unchecked arith from ssz_derive * Address clippy lints in block_verfication * Use safe math for is_valid_gas_limit
paulhauner
added a commit
that referenced
this pull request
Nov 11, 2021
* Remove unchecked arith from ssz_derive * Address clippy lints in block_verfication * Use safe math for is_valid_gas_limit
paulhauner
added a commit
that referenced
this pull request
Nov 28, 2021
* Remove unchecked arith from ssz_derive * Address clippy lints in block_verfication * Use safe math for is_valid_gas_limit
paulhauner
added a commit
that referenced
this pull request
Nov 28, 2021
* Remove unchecked arith from ssz_derive * Address clippy lints in block_verfication * Use safe math for is_valid_gas_limit
paulhauner
added a commit
that referenced
this pull request
Dec 2, 2021
* Remove unchecked arith from ssz_derive * Address clippy lints in block_verfication * Use safe math for is_valid_gas_limit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
NA
Proposed Changes
Fixes all clippy lints on the
merge-f2fbranch.Additional Info
NA