Finished Gossip Block Validation Conditions #2640
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulhauner
requested changes
Sep 27, 2021
Member
paulhauner
left a comment
paulhauner
left a comment
There was a problem hiding this comment.
Looks good, just one TODO to remove
realbigsean
reviewed
Sep 28, 2021
| /// An implementation of the method described in the consensus spec here: | ||
| /// | ||
| /// https://github.com/ethereum/consensus-specs/blob/dev/specs/merge/beacon-chain.md#compute_timestamp_at_slot | ||
| fn compute_timestamp_at_slot(&self, slot: Slot) -> Option<u64> { |
Member
There was a problem hiding this comment.
This PR adds a second implementation of compute_timestamp_at_slot in the SlotClock to avoid accessing the head during block verification just to get the genesis_time. The original implementation still exists and is used in the consensus code, because we don't pass the SlotClock around the consensus code (and to keep the consensus code more similar to the spec). Wondering if people think that seems reasonable? Or should we try to keep a single implementation everywhere
Member
There was a problem hiding this comment.
Yep, I think this is a good idea. It's a simple enough function that I think it's worth the trade-off.
Very neat and correct impl too 🏅
paulhauner
reviewed
Sep 28, 2021
paulhauner
force-pushed
the
merge-f2f
branch
from
a11c92c to
e559bd9
Compare
ethDreamer
force-pushed
the
block-validation
branch
from
8283199 to
e4445e1
Compare
paulhauner
pushed a commit
that referenced
this pull request
Oct 1, 2021
* Gossip Block Validation is Much More Efficient Co-authored-by: realbigsean <[email protected]>
paulhauner
pushed a commit
that referenced
this pull request
Oct 12, 2021
* Gossip Block Validation is Much More Efficient Co-authored-by: realbigsean <[email protected]>
paulhauner
pushed a commit
that referenced
this pull request
Oct 27, 2021
* Gossip Block Validation is Much More Efficient Co-authored-by: realbigsean <[email protected]>
paulhauner
pushed a commit
to paulhauner/lighthouse
that referenced
this pull request
Nov 3, 2021
* Gossip Block Validation is Much More Efficient Co-authored-by: realbigsean <[email protected]>
paulhauner
pushed a commit
that referenced
this pull request
Nov 11, 2021
* Gossip Block Validation is Much More Efficient Co-authored-by: realbigsean <[email protected]>
paulhauner
pushed a commit
that referenced
this pull request
Nov 28, 2021
* Gossip Block Validation is Much More Efficient Co-authored-by: realbigsean <[email protected]>
paulhauner
pushed a commit
that referenced
this pull request
Nov 28, 2021
* Gossip Block Validation is Much More Efficient Co-authored-by: realbigsean <[email protected]>
paulhauner
pushed a commit
that referenced
this pull request
Dec 2, 2021
* Gossip Block Validation is Much More Efficient Co-authored-by: realbigsean <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finished implementing the gossip block validation conditions.