Skip to content

Conversation

@paulhauner
Copy link
Member

Issue Addressed

NA

Proposed Changes

Includes the test vectors documented here: https://notes.ethereum.org/@9AeMAlpyQYaAAyuj47BzRw/rkwW3ceVY

I had to make a few changes to get these vectors to pass, so they served their purpose well!

Additional Info

NA

@paulhauner paulhauner added ready-for-review The code is ready for review merge-f2f Relates to the Oct 2021 Merge F2F labels Sep 30, 2021
Copy link
Member

@AgeManning AgeManning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@paulhauner paulhauner merged commit 3a60abd into sigp:merge-f2f Oct 1, 2021
paulhauner added a commit that referenced this pull request Oct 1, 2021
* Add geth request vectors

* Add geth response vectors

* Fix clippy lints
paulhauner added a commit that referenced this pull request Oct 12, 2021
* Add geth request vectors

* Add geth response vectors

* Fix clippy lints
paulhauner added a commit that referenced this pull request Oct 27, 2021
* Add geth request vectors

* Add geth response vectors

* Fix clippy lints
paulhauner added a commit to paulhauner/lighthouse that referenced this pull request Nov 3, 2021
* Add geth request vectors

* Add geth response vectors

* Fix clippy lints
paulhauner added a commit that referenced this pull request Nov 11, 2021
* Add geth request vectors

* Add geth response vectors

* Fix clippy lints
paulhauner added a commit that referenced this pull request Nov 28, 2021
* Add geth request vectors

* Add geth response vectors

* Fix clippy lints
paulhauner added a commit that referenced this pull request Nov 28, 2021
* Add geth request vectors

* Add geth response vectors

* Fix clippy lints
paulhauner added a commit that referenced this pull request Dec 2, 2021
* Add geth request vectors

* Add geth response vectors

* Fix clippy lints
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge-f2f Relates to the Oct 2021 Merge F2F ready-for-review The code is ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants