Skip to content

Conversation

@realbigsean
Copy link
Member

@realbigsean realbigsean commented Oct 6, 2021

Proposed Changes

  • Spec updates to initialize_beacon_state_from_eth1
  • Add flag lcli new-testnet --execution-payload-header FILE to allow starting from a merge genesis with or without an execution payload header
  • Add a lcli create-payload-header command to create the file used in the prior command ^

Additional Info

@realbigsean realbigsean added blocked merge-f2f Relates to the Oct 2021 Merge F2F ready-for-review The code is ready for review labels Oct 6, 2021
Copy link
Member

@paulhauner paulhauner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome 🚀

There's just tiny typo to fix, then it's good to go.

Since we're just merging into merge-f2f I think we should merge with those EF tests failing and wait for a good version.

@paulhauner
Copy link
Member

paulhauner commented Oct 7, 2021

It turns out I had permission to add those suggestions 🎉

If CI passes I'll merge it :)

@paulhauner paulhauner merged commit 0a289c4 into sigp:merge-f2f Oct 8, 2021
paulhauner added a commit that referenced this pull request Oct 12, 2021
* update initializing from eth1 for merge genesis

* read execution payload header from file lcli

* add `create-payload-header` command to `lcli`

* fix base fee parsing

* Apply suggestions from code review

* default `execution_payload_header` bool to false when deserializing `meta.yml` in EF tests

Co-authored-by: Paul Hauner <[email protected]>
paulhauner added a commit that referenced this pull request Oct 27, 2021
* update initializing from eth1 for merge genesis

* read execution payload header from file lcli

* add `create-payload-header` command to `lcli`

* fix base fee parsing

* Apply suggestions from code review

* default `execution_payload_header` bool to false when deserializing `meta.yml` in EF tests

Co-authored-by: Paul Hauner <[email protected]>
paulhauner added a commit to paulhauner/lighthouse that referenced this pull request Nov 3, 2021
* update initializing from eth1 for merge genesis

* read execution payload header from file lcli

* add `create-payload-header` command to `lcli`

* fix base fee parsing

* Apply suggestions from code review

* default `execution_payload_header` bool to false when deserializing `meta.yml` in EF tests

Co-authored-by: Paul Hauner <[email protected]>
paulhauner added a commit that referenced this pull request Nov 11, 2021
* update initializing from eth1 for merge genesis

* read execution payload header from file lcli

* add `create-payload-header` command to `lcli`

* fix base fee parsing

* Apply suggestions from code review

* default `execution_payload_header` bool to false when deserializing `meta.yml` in EF tests

Co-authored-by: Paul Hauner <[email protected]>
paulhauner added a commit that referenced this pull request Nov 28, 2021
* update initializing from eth1 for merge genesis

* read execution payload header from file lcli

* add `create-payload-header` command to `lcli`

* fix base fee parsing

* Apply suggestions from code review

* default `execution_payload_header` bool to false when deserializing `meta.yml` in EF tests

Co-authored-by: Paul Hauner <[email protected]>
paulhauner added a commit that referenced this pull request Nov 28, 2021
* update initializing from eth1 for merge genesis

* read execution payload header from file lcli

* add `create-payload-header` command to `lcli`

* fix base fee parsing

* Apply suggestions from code review

* default `execution_payload_header` bool to false when deserializing `meta.yml` in EF tests

Co-authored-by: Paul Hauner <[email protected]>
paulhauner added a commit that referenced this pull request Dec 2, 2021
* update initializing from eth1 for merge genesis

* read execution payload header from file lcli

* add `create-payload-header` command to `lcli`

* fix base fee parsing

* Apply suggestions from code review

* default `execution_payload_header` bool to false when deserializing `meta.yml` in EF tests

Co-authored-by: Paul Hauner <[email protected]>
@realbigsean realbigsean deleted the merge-initialize-from-eth1 branch November 21, 2023 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

blocked merge-f2f Relates to the Oct 2021 Merge F2F ready-for-review The code is ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants