Skip to content

fsync during backfill to prevent DB corruption #5144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 30, 2024
Merged

fsync during backfill to prevent DB corruption #5144

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions beacon_node/beacon_chain/src/historical_blocks.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,8 +206,14 @@ impl<T: BeaconChainTypes> BeaconChain<T> {
drop(sig_timer);

// Write the I/O batches to disk.
// We fsync after each write because we need the writes to the blob and freezer DB to
// be persisted if the writes to the hot DB are persisted. Without fsync we could end up
// in a situation where the hot DB's anchor is updated but the actual blocks are forgotten
// from disk.
self.store.blobs_db.do_atomically(blob_batch)?;
self.store.blobs_db.sync()?;
self.store.cold_db.do_atomically(cold_batch)?;
self.store.cold_db.sync()?;

let mut anchor_and_blob_batch = Vec::with_capacity(2);

Expand Down Expand Up @@ -237,6 +243,7 @@ impl<T: BeaconChainTypes> BeaconChain<T> {
.compare_and_set_anchor_info(Some(anchor_info), Some(new_anchor))?,
);
self.store.hot_db.do_atomically(anchor_and_blob_batch)?;
self.store.hot_db.sync()?;

// If backfill has completed and the chain is configured to reconstruct historic states,
// send a message to the background migrator instructing it to begin reconstruction.
Expand Down