Remove milhouse export aliases #5286
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dapplion
added
ready-for-review
dapplion
force-pushed
the
tree-states-rename
branch
from
e2447d4 to
7938a43
Compare
michaelsproul
approved these changes
Feb 27, 2024
Member
michaelsproul
left a comment
michaelsproul
left a comment
There was a problem hiding this comment.
Niiiiice, thanks for cleaning this up!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment
tree-stateshas a confusing mix of type aliases for theVariableList/FixedVectortypes. This PR switches to:VariableList/FixedVector: same as onstable, refer to types fromssz_typesList/Vector: unmodifiedmilhousetype namesIssue Addressed
Closes #5141