Log warning on startup if chain spec contains misaligned fork epochs #5859
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimmygchen
force-pushed
the
warn-invalid-fork-epochs
branch
from
244a1de to
a41f1ed
Compare
dapplion
reviewed
May 30, 2024
Collaborator
dapplion
left a comment
dapplion
left a comment
There was a problem hiding this comment.
I am thinking who is the person that needs to see this warn. Anyone consuming lightclient data could be affected by an improperly aligned fork, which is a bigger group than the node operator. However, in practice no real network will adopt a bad fork epoch. This should apply to local devnets or experiments.
Member
Author
|
The intent was mainly for setting up expectation and giving a heads up on the configuration during testing (local devnet / testnets). So yes, this only applies to local devnet and experiments, and we should never see this on a production network. |
jimmygchen
added
ready-for-merge
Member
Author
|
@mergify queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 4c7277c |
This was referenced Jul 11, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Addresses this comment: #4946 (comment)
If fork epochs are not multiples of 256, sync committee period may span across forks - this is mostly fine for non-production and testing code unrelated to light client. Adding a check would be useful for identifying issues with future forks / light client testing.
Proposed Changes
Check fork epochs in the
ChainSpecare aligned with the start of sync committee period, otherwise log a warning durinog startup.