Skip to content

Conversation

@ltitanb
Copy link
Contributor

@ltitanb ltitanb commented Aug 28, 2025

implement Display and Error to make it more ergonomic for library users

@macladson macladson mentioned this pull request Sep 24, 2025
@codecov
Copy link

codecov bot commented Sep 24, 2025

Codecov Report

❌ Patch coverage is 14.28571% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 57.18%. Comparing base (c655ac2) to head (0c5eb18).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/lib.rs 14.28% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #56      +/-   ##
==========================================
- Coverage   59.00%   57.18%   -1.82%     
==========================================
  Files          10       10              
  Lines         300      313      +13     
==========================================
+ Hits          177      179       +2     
- Misses        123      134      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@michaelsproul
Copy link
Member

This is a breaking change, so we can include it in 0.13

Copy link
Member

@macladson macladson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ltitanb, if you have time to fix these conflicts we can merge this

@ltitanb
Copy link
Contributor Author

ltitanb commented Nov 11, 2025

done @macladson

@macladson macladson merged commit 8e5b6df into sigp:main Nov 11, 2025
7 of 9 checks passed
@macladson macladson mentioned this pull request Nov 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants