Skip to content

Return Public key in sign-blob when no certificate can be extracted. #4224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Return Public key in sign-blob when no certificate can be extracted. #4224

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8002de8
Encoding Public Key when no cert is present in sign-blob request
tommyd450 Jun 6, 2025
5746084
Checking if signer has cert in cosign sign
tommyd450 Jul 24, 2025
3c2ea03
Removing unused package
tommyd450 Jul 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cmd/cosign/cli/sign/sign.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -294,7 +294,7 @@
}

if signOpts.OutputCertificate != "" {
rekorBytes, err := sv.Bytes(ctx)
rekorBytes, err := extractCertificate(ctx,sv)

Check failure on line 297 in cmd/cosign/cli/sign/sign.go

View workflow job for this annotation

GitHub Actions / lint 

File is not properly formatted (goimports)

Check failure on line 297 in cmd/cosign/cli/sign/sign.go

View workflow job for this annotation

GitHub Actions / lint 

File is not properly formatted (gofmt)
if err != nil {
return fmt.Errorf("create certificate file: %w", err)
}
Expand Down
4 changes: 2 additions & 2 deletions cmd/cosign/cli/sign/sign_blob.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@
// nolint
func SignBlobCmd(ro *options.RootOptions, ko options.KeyOpts, payloadPath string, b64 bool, outputSignature string, outputCertificate string, tlogUpload bool) ([]byte, error) {
var payload internal.HashReader

var err error
ctx, cancel := context.WithTimeout(context.Background(), ro.Timeout)
defer cancel()

Expand Down Expand Up @@ -240,7 +240,7 @@
return nil, fmt.Errorf("create certificate file: %w", err)
}
ui.Infof(ctx, "Wrote certificate to file %s", outputCertificate)
}
}

Check failure on line 243 in cmd/cosign/cli/sign/sign_blob.go

View workflow job for this annotation

GitHub Actions / Check Whitespace 

[trailing whitespace] reported by reviewdog 🐶
Space at end of line

Raw Output:
cmd/cosign/cli/sign/sign_blob.go:243:Space at end of line
}

return sig, nil
Expand Down
Loading