Skip to content

Conversation

@joonas
Copy link
Contributor

@joonas joonas commented Oct 23, 2025

Summary

While spelunking through the code and some history, I noticed this stale import for embed that was originally introduced in #530 and subsequently removed the need for in #747, but the import wasn't removed as part of that change.

Release Note

NONE

Documentation

NONE

Signed-off-by: Joonas Bergius <[email protected]>
@joonas joonas requested a review from a team as a code owner October 23, 2025 23:20
@codecov
Copy link

codecov bot commented Oct 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 36.74%. Comparing base (2ef6022) to head (f13962f).
⚠️ Report is 569 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4492      +/-   ##
==========================================
- Coverage   40.10%   36.74%   -3.36%     
==========================================
  Files         155      220      +65     
  Lines       10044    12116    +2072     
==========================================
+ Hits         4028     4452     +424     
- Misses       5530     6976    +1446     
- Partials      486      688     +202     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bobcallaway bobcallaway merged commit 1861d59 into sigstore:main Oct 24, 2025
29 checks passed
@joonas joonas deleted the chore/remove-stale-embed branch October 24, 2025 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants