Fix i18n for emails #535
Closed
Fix i18n for emails #535
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
C# Unit Tests39 tests 39 ✅ 5s ⏱️ Results for commit 15dc393. ♻️ This comment has been updated with latest results. |
hahn-kev
requested changes
Feb 2, 2024
4 tasks
|
This PR is now on hold. See #545. |
|
Will be covered in #545 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #534
Init i18n for emails and send Accept-Language header to svelte when rendering emails.
I also opened a tiny PR upstream that would let us tidy up the .NET code a tad.