Fix handling of implicitly closed char styles when updating USFM #170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #170 +/- ##
=======================================
Coverage 88.63% 88.64%
=======================================
Files 277 277
Lines 16621 16632 +11
=======================================
+ Hits 14732 14743 +11
Misses 1889 1889 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ddaspit
force-pushed
the
implicitly-closed-style
branch
from
66fb5b4 to
546fe70
Compare
Enkidu93
approved these changes
Apr 28, 2025
There was a problem hiding this comment.
This looks good to me! (...but of course, John's more familiar with this issue and with this part of the code)
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @johnml1135)
- only skip/collect tokens if the marker is explicitly closed - fm markers are not footnote elements - only end note text when a ft marker is closed
ddaspit
force-pushed
the
implicitly-closed-style
branch
from
546fe70 to
37e36db
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is