Skip to content

Conversation

Enkidu93
Copy link
Collaborator

@Enkidu93 Enkidu93 commented May 19, 2025

  • Make align_pretranslations configurable in build_options
  • Don't try to ingest non-existent pretranslation.src.json properties

Related to sillsdev/serval#663


This change is Reviewable

… to ingest non-existent pretranslation properties
@Enkidu93 Enkidu93 requested review from ddaspit and isaac091 May 19, 2025 20:29
@Enkidu93
Copy link
Collaborator Author

While I was digging into this testing it and trying to get some sample output pretranslation jsons, I realized that it's not particularly straightforward to run machine.py nmt jobs locally end-to-end. Is there an issue already for making a dummy translation job for testing? What's in the launch.json doesn't work well locally and the code isn't set up for using the cpu.

@codecov-commenter
Copy link

codecov-commenter commented May 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.87%. Comparing base (0ff0f8d) to head (bdd0ad1).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #179   +/-   ##
=======================================
  Coverage   88.87%   88.87%           
=======================================
  Files         282      282           
  Lines       16951    16951           
=======================================
  Hits        15065    15065           
  Misses       1886     1886           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@ddaspit ddaspit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 2 files at r1, 4 of 4 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @isaac091)

@Enkidu93 Enkidu93 merged commit 0354cc7 into main May 22, 2025
14 checks passed
@Enkidu93 Enkidu93 deleted the pass_alignments_to_serval branch May 22, 2025 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants