-
-
Notifications
You must be signed in to change notification settings - Fork 3
Report additional ClearML progress via user properties #205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One of the disadvantages of using Task.set_user_properties
is that it isn't async. This could have a negative impact on performance, since setting the progress properties is now blocking. Luckily, we've already implemented throttling, so that should help. We should keep an eye on it.
You can remove the AsyncScheduler
class, since it is no longer used.
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @pmachapman)
6d41810
to
da5565b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #205 +/- ##
=======================================
Coverage 88.89% 88.89%
=======================================
Files 282 282
Lines 17061 17061
=======================================
Hits 15167 15167
Misses 1894 1894 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One of the disadvantages of using
Task.set_user_properties
is that it isn't async. This could have a negative impact on performance, since setting the progress properties is now blocking. Luckily, we've already implemented throttling, so that should help. We should keep an eye on it.
Definitely something to keep an eye on. Worst case, we reimplement the calls using AsyncScheduler
.
You can remove the
AsyncScheduler
class, since it is no longer used.
Thanks for spotting this - done.
Reviewable status: 4 of 5 files reviewed, all discussions resolved (waiting on @ddaspit)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @pmachapman)
da5565b
to
2f97877
Compare
This PR changes the separate progress reporting and message that were previously reported via runtime to now be reported via user properties (cf. clearml/clearml#1432).
This updates the properties tab in ClearML to look something like this for NMT jobs:

And this for SMT jobs:

This change is