Skip to content

Conversation

pmachapman
Copy link
Collaborator

@pmachapman pmachapman commented Jul 7, 2025

This PR changes the separate progress reporting and message that were previously reported via runtime to now be reported via user properties (cf. clearml/clearml#1432).

This updates the properties tab in ClearML to look something like this for NMT jobs:
image

And this for SMT jobs:
image


This change is Reviewable

Copy link
Contributor

@ddaspit ddaspit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One of the disadvantages of using Task.set_user_properties is that it isn't async. This could have a negative impact on performance, since setting the progress properties is now blocking. Luckily, we've already implemented throttling, so that should help. We should keep an eye on it.

You can remove the AsyncScheduler class, since it is no longer used.

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @pmachapman)

@pmachapman pmachapman force-pushed the clearml_user_properties branch from 6d41810 to da5565b Compare July 8, 2025 20:16
@codecov-commenter
Copy link

codecov-commenter commented Jul 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.89%. Comparing base (ed8b7fa) to head (2f97877).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #205   +/-   ##
=======================================
  Coverage   88.89%   88.89%           
=======================================
  Files         282      282           
  Lines       17061    17061           
=======================================
  Hits        15167    15167           
  Misses       1894     1894           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator Author

@pmachapman pmachapman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One of the disadvantages of using Task.set_user_properties is that it isn't async. This could have a negative impact on performance, since setting the progress properties is now blocking. Luckily, we've already implemented throttling, so that should help. We should keep an eye on it.

Definitely something to keep an eye on. Worst case, we reimplement the calls using AsyncScheduler.

You can remove the AsyncScheduler class, since it is no longer used.

Thanks for spotting this - done.

Reviewable status: 4 of 5 files reviewed, all discussions resolved (waiting on @ddaspit)

@pmachapman pmachapman requested a review from ddaspit July 8, 2025 20:24
Copy link
Contributor

@ddaspit ddaspit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @pmachapman)

@pmachapman pmachapman force-pushed the clearml_user_properties branch from da5565b to 2f97877 Compare July 16, 2025 00:07
@pmachapman pmachapman merged commit 8670e84 into main Jul 16, 2025
14 checks passed
@pmachapman pmachapman deleted the clearml_user_properties branch July 16, 2025 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants