Skip to content

custom message for type errors when parsing build options #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 5, 2023
Merged

custom message for type errors when parsing build options #37

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion machine/jobs/build_nmt_engine.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,8 @@ def clearml_check_canceled() -> None:
SETTINGS.build_options = json.loads(args["build_options"])
except ValueError as e:
raise ValueError("Build options could not be parsed: Invalid JSON") from e
except TypeError as e:
raise TypeError(f"Build options could not be parsed: {e}") from e
if SETTINGS.build_options:
SETTINGS.update(SETTINGS.build_options)
SETTINGS.data_dir = os.path.expanduser(cast(str, SETTINGS.data_dir))
Expand Down Expand Up @@ -74,7 +76,7 @@ def main() -> None:
parser.add_argument("--src-lang", required=True, type=str, help="Source language tag")
parser.add_argument("--trg-lang", required=True, type=str, help="Target language tag")
parser.add_argument("--clearml", default=False, action="store_true", help="Initializes a ClearML task")
parser.add_argument("--build-options", default="{}", help="Build configurations")
parser.add_argument("--build-options", default="{}", type=str, help="Build configurations")
args = parser.parse_args()

run({k: v for k, v in vars(args).items() if v is not None})
Expand Down