Skip to content

Conversation

@pmachapman
Copy link
Collaborator

@pmachapman pmachapman commented Aug 20, 2025

This PR excludes the id segment from the translated segment count, as this is a segment that is not translated, and will usually have text.


This change is Reviewable

@pmachapman pmachapman added the will require testing PR should not be merged until testers confirm testing is complete label Aug 20, 2025
@RaymondLuong3 RaymondLuong3 self-assigned this Aug 20, 2025
Copy link
Collaborator

@RaymondLuong3 RaymondLuong3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RaymondLuong3 reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @pmachapman)

@RaymondLuong3 RaymondLuong3 added ready to test and removed will require testing PR should not be merged until testers confirm testing is complete labels Aug 20, 2025
@Nateowami Nateowami added testing complete Testing of PR is complete and should no longer hold up merging of the PR and removed ready to test labels Aug 21, 2025
@codecov
Copy link

codecov bot commented Aug 21, 2025

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.22%. Comparing base (a6d6ce8) to head (b660ff6).
⚠️ Report is 81 commits behind head on master.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...cripture/ClientApp/src/app/core/models/text-doc.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3384      +/-   ##
==========================================
- Coverage   82.22%   82.22%   -0.01%     
==========================================
  Files         609      609              
  Lines       35949    35950       +1     
  Branches     5879     5880       +1     
==========================================
  Hits        29560    29560              
- Misses       5525     5526       +1     
  Partials      864      864              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Nateowami Nateowami merged commit efc5f6a into master Aug 21, 2025
18 checks passed
@Nateowami Nateowami deleted the fix/SF-3518 branch August 21, 2025 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testing complete Testing of PR is complete and should no longer hold up merging of the PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants