Feat lowside samd21 #479
Merged
Feat lowside samd21 #479
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
askuric
changed the base branch from
master
to
feat_current_sense_check_for_trgo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So this PR implements a different strategy for low-side current sensing with SAMD21.
It's inspired by the od code but no longer used DMA.
I've had some issues with the old code, could not run it and even compile it as the library AdafruitZeroDMA uses some same funciton calls that we cannot really chnage.
So I've passed to the timer-synced interrupt based approach.
It is once again one phase sample per PWM cycle, not the best really. But it does work.
I've tested: