Ignore true/false/1/0 values for CACHE_DIR environment variable
#27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Richie Bendall <[email protected]>
ronjouch
approved these changes
Mar 7, 2020
There was a problem hiding this comment.
👏 to fix #26, but I still find CACHE_DIR to be a very generic, collision-prone env. var name. I wish Shippable had used something more targeted, and maybe find-cache-dir could too.
Up to you. At any rate, thanks for the help and fast fix 🙂.
sindresorhus
reviewed
Mar 8, 2020
sindresorhus
reviewed
Mar 8, 2020
Co-Authored-By: Sindre Sorhus <[email protected]>
Signed-off-by: Richie Bendall <[email protected]>
sindresorhus
reviewed
Mar 9, 2020
sindresorhus
reviewed
Mar 9, 2020
sindresorhus
reviewed
Mar 9, 2020
Signed-off-by: Richie Bendall <[email protected]>
sindresorhus
changed the title
CACHE_DIR environment variableCACHE_DIR environment variable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #26
cc @sindresorhus @ronjouch