Skip to content

Conversation

zimeg
Copy link
Member

@zimeg zimeg commented Sep 25, 2025

Summary

This PR has a workaround for #1374 to use cheroot<11 in adapter tests.

Testing

Works on my machine and I hope CI now too. Huge kind thanks to @WilliamBergamin for helping me fix my test running setups! 🙏 ✨

Notes

I don't believe we should close the linked issue with this, but was wanting to unblock CI for ongoing finding! 🔍

Category

  • Adapters in slack_bolt.adapter

Requirements

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run ./scripts/install_all_and_run_tests.sh after making the changes.

@zimeg zimeg added this to the 1.25.1 milestone Sep 25, 2025
@zimeg zimeg self-assigned this Sep 25, 2025
@zimeg zimeg added bug Something isn't working area:adapter dependencies Pull requests that update a dependency file tests semver:patch labels Sep 25, 2025
Copy link
Member

@mwbrooks mwbrooks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Thanks for taking the time to dig into the failing tests. This looks like a hopeful patch to get our CI/CD back up until we can support the latest updates of cherrpy.

boto3<=2
bottle>=0.12,<1
chalice>=1.28,<2;
cheroot<11 # https://github.com/slackapi/bolt-python/issues/1374
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

praise: Thanks for linking the issue so we know why we're requiring a lower version of cheroot. Let's hope this works on the CI side as well! 🤞🏻

Copy link

codecov bot commented Sep 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.00%. Comparing base (7cedaac) to head (bc9879f).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1375   +/-   ##
=======================================
  Coverage   91.00%   91.00%           
=======================================
  Files         222      222           
  Lines        7512     7512           
=======================================
  Hits         6836     6836           
  Misses        676      676           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zimeg
Copy link
Member Author

zimeg commented Sep 25, 2025

@mwbrooks I'm so glad we narrowed this down to a version update too! 🔏

Let's merge this now to follow up on the linked issue. I also agree that this isn't an ideal fix but perhaps revisiting this in a change upstream might resolve things? Let's discuss in issue! 🧪 ✨

@zimeg zimeg merged commit 811d6a2 into main Sep 25, 2025
14 checks passed
@zimeg zimeg deleted the zimeg-fix-adapter-cheroot-11 branch September 25, 2025 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:adapter bug Something isn't working dependencies Pull requests that update a dependency file semver:patch tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants